Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocess release name #7

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

garyschulte
Copy link
Owner

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte merged commit 3372fc4 into main Aug 19, 2024
27 checks passed
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces preprocessing of the release name in the release workflow for the Besu project. Key changes include:

  • Added a "Preprocess Release Name" step in the artifacts job of .github/workflows/release.yml
  • Implemented trimming of leading and trailing spaces from the release name
  • Added validation to ensure the release name conforms to the format YY.M.v[-suffix] (e.g., 24.8.0-RC1)
  • Stored the processed release name in the GITHUB_ENV for use in subsequent steps

These changes aim to improve the robustness of the release process by ensuring consistent and valid release naming conventions.

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant