Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Add multiple images support #112

Closed

Conversation

zhusupbekova
Copy link

Hey, everyone!

I hacked together a solution to make multiple images fields supported.
Let me know if there are any changes required.

Hope to get this merged because this is a very crucial feature for our current project.

Thank you!

@denisgoryaynov
Copy link
Contributor

denisgoryaynov commented Apr 3, 2020

@zhusupbekova this PR is great and and allows to query multiple images without using the localFile field like mine does, the only issue I have is that it doesn't work in this case:

query Test {
  allStrapiProject {
    nodes {
      title
      multipleMedia {
        publicURL
      }
      section {
        multipleMedia {
          publicURL
        }
      }
    }
  }
}

while it allows me to query the publicURL field inside the section it doesn't work for querying the publicURL on the first multipleMedia. I solved it by removing the return on line 33 of src/normalize.js (you shouldn't return because there may be other arrays of images like in my case). If you can fix it it would be great and I hope it will be merged.

@tonoli
Copy link

tonoli commented Jun 11, 2020

Any update on this?

@alexandrebodin alexandrebodin mentioned this pull request Nov 18, 2020
@strapi-cla
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alexandrebodin
Copy link
Contributor

Hi, We just released the v1.0.0 fixing including this requested changes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants