chore: minor tweaks and improvements #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
added a commit
to gatsbyjs/gatsby
that referenced
this pull request
Dec 20, 2018
This PR adds in starters to the monorepo. Longer term, I believe we'll merge starters/examples since they're very much linked. Future implementation improvements: - Run a `build` script to validate that the starter(s) can be built - I planned to use `lerna run --scope gatsby-starter-*` for this, but if there's another approach, happy to try that - Implement yarn workspaces/lerna so we can get automatic versioning in the starters (I have this built out at https://github.com/dschau/starters) - Author `e2e` tests vs. the starters so that we can ensure we're not breaking anything - These would follow a similar approach to the current e2e tests Blocked by gatsbyjs/gatsby-starter-blog#139 gatsbyjs/gatsby-starter-default#120 gatsbyjs/gatsby-starter-hello-world#32
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
This PR adds in starters to the monorepo. Longer term, I believe we'll merge starters/examples since they're very much linked. Future implementation improvements: - Run a `build` script to validate that the starter(s) can be built - I planned to use `lerna run --scope gatsby-starter-*` for this, but if there's another approach, happy to try that - Implement yarn workspaces/lerna so we can get automatic versioning in the starters (I have this built out at https://github.com/dschau/starters) - Author `e2e` tests vs. the starters so that we can ensure we're not breaking anything - These would follow a similar approach to the current e2e tests Blocked by gatsbyjs/gatsby-starter-blog#139 gatsbyjs/gatsby-starter-default#120 gatsbyjs/gatsby-starter-hello-world#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.