test: add tests

gatsbyjs · Sep 19, 2019 · 870def4 · 870def4
1 parent f0ef733
commit 870def4
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 5 deletions.
diff --git a/packages/gatsby/src/utils/__tests__/validate-plugin-options.js b/packages/gatsby/src/utils/__tests__/validate-plugin-options.js
@@ -27,6 +27,37 @@ describe(`validating plugin options`, () => {
       })
     })
 
+    describe(`plugin validation`, () => {
+      test.each([
+        [
+          `validates string shape`,
+          [`gatsby-plugin-react-helmet`, `gatsby-plugin-yolo`],
+        ],
+        [
+          `validates object shape`,
+          [
+            {
+              resolve: `gatsby-plugin-remark`,
+              options: {
+                plugins: [],
+              },
+            },
+          ],
+        ],
+      ])(`%p`, (_, plugins) => {
+        expect(
+          validatePluginOptions(schema, {
+            ...defaultOpts,
+            plugins,
+          })
+        ).resolves.toEqual(
+          expect.objectContaining({
+            plugins,
+          })
+        )
+      })
+    })
+
     it(`does not bail on first error`, async () => {
       try {
         await validatePluginOptions(schema, {})
@@ -37,11 +68,17 @@ describe(`validating plugin options`, () => {
       }
     })
 
-    it(`does not bail on unknown keys`, () => {
+    it(`bails on unknown keys`, async () => {
       const extra = { d: `d` }
-      expect(
-        validatePluginOptions(schema, { ...defaultOpts, ...extra })
-      ).resolves.toEqual(expect.objectContaining(extra))
+      try {
+        await validatePluginOptions(schema, { ...defaultOpts, ...extra })
+      } catch (e) {
+        expect(e.details[0].message).toEqual(
+          expect.stringContaining(`is not allowed`)
+        )
+      } finally {
+        expect.hasAssertions()
+      }
     })
   })
 })

diff --git a/packages/gatsby/src/utils/validate-plugin-options.js b/packages/gatsby/src/utils/validate-plugin-options.js
@@ -1,7 +1,7 @@
 const Joi = require(`@hapi/joi`)
 
 const baseSchema = Joi.object().keys({
-  plugins: Joi.array(
+  plugins: Joi.array().items(
     Joi.alternatives(
       Joi.string(),
       Joi.object().keys({