Better error handling with reporter.panic

gatsbyjs · Mar 4, 2019 · cb3902c · cb3902c
1 parent fde992e
commit cb3902c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/packages/gatsby-remark-code-repls/src/__tests__/gatsby-node.js b/packages/gatsby-remark-code-repls/src/__tests__/gatsby-node.js
@@ -5,10 +5,17 @@ jest.mock(`fs`, () => {
   }
 })
 jest.mock(`recursive-readdir`, () => jest.fn())
+jest.mock(`gatsby-cli/lib/reporter`, () => {
+  return {
+    panic: jest.fn(),
+  }
+})
 
 const fs = require(`fs`)
 const readdir = require(`recursive-readdir`)
 
+const reporter = require(`gatsby-cli/lib/reporter`)
+
 const {
   OPTION_DEFAULT_HTML,
   OPTION_DEFAULT_REDIRECT_TEMPLATE_PATH,
@@ -20,6 +27,7 @@ const createPagesParams = {
   actions: {
     createPage,
   },
+  reporter,
 }
 
 describe(`gatsby-remark-code-repls`, () => {

diff --git a/packages/gatsby-remark-code-repls/src/gatsby-node.js b/packages/gatsby-remark-code-repls/src/gatsby-node.js
@@ -12,7 +12,7 @@ const {
 } = require(`./constants`)
 
 exports.createPages = async (
-  { actions },
+  { actions, reporter },
   {
     directory = OPTION_DEFAULT_LINK_TEXT,
     externals = [],
@@ -27,11 +27,11 @@ exports.createPages = async (
   const { createPage } = actions
 
   if (!fs.existsSync(directory)) {
-    throw Error(`Invalid REPL directory specified: "${directory}"`)
+    reporter.panic(`Invalid REPL directory specified: "${directory}"`)
   }
 
   if (!fs.existsSync(redirectTemplate)) {
-    throw Error(
+    reporter.panic(
       `Invalid REPL redirectTemplate specified: "${redirectTemplate}"`
     )
   }
@@ -75,7 +75,12 @@ exports.createPages = async (
       }
     })
   } catch (error) {
-    // retrow errors upstream
-    throw error
+    reporter.panic(
+      `
+      Error in gatsby-remark-code-repls plugin: cannot read directory ${directory}.
+      More details can be found in the error reporting below.
+      `,
+      error
+    )
   }
 }