-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security] Upgrade minimatch to fix RegEx DoS security issue #10282
Comments
I’ll try to work this out when I can spare some time! Also this is a good opportunity to refactor the package, see gatsby/packages/gatsby-remark-code-repls/src/gatsby-node.js Lines 39 to 42 in 9bd0a27
|
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! Thanks for being a part of the Gatsby community! 💪💜 |
Issue is not stale, PR #10338 is still alive and kickin’ |
Hey again! It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m Thanks again for being part of the Gatsby community! |
Fixes #10282 - [x] Switch to `recursive-readdir` library - [x] Implement async readdir behavior - [x] Fix existing tests - [x] Test error handling - [x] Test on a `gatsby-starter-blog` with few examples of REPLs - [x] Try and implement the `Promise.all` refactor
See #10198 for context.
Description
One of the dependencies of the
gatsby-remark-code-repls
package relies on an outdated version ofminimatch
that allows for a Regular Expression Denial of Service (see npm report on the matter)Steps to reproduce
Run
yarn audit
and see the high severity security issue.The text was updated successfully, but these errors were encountered: