Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from HTML source #172

Closed
kristofferh opened this issue Mar 5, 2016 · 4 comments · May be fixed by tejzpr/gatsby#63
Closed

Building from HTML source #172

kristofferh opened this issue Mar 5, 2016 · 4 comments · May be fixed by tejzpr/gatsby#63

Comments

@kristofferh
Copy link
Contributor

Hey there!

I can't seem to generate static pages when I have an HTML page in the hierarchy -- it's completely possible that I'm doing something wrong.

In /pages if I create a new file (or folder with an index.html file), say test.html with the contents:


---
title: Hello

---
<p>hi</p>

When I run gatsby build it fails and throws.

Error: TypeError: Cannot read property 'data' of undefined

@KyleAMathews
Copy link
Contributor

So this is not a very obvious at all error but since I just ran into it when playing around with the default starter, I'm pretty sure the reason is you're missing a react.js wrapper for HTML content.

Try creating a file at wrappers/html.js with the following in it and see what happens.

import React from 'react'

module.exports = React.createClass({
  propTypes () {
    return {
      router: React.PropTypes.object,
    }
  },
  render () {
    console.log(this.props.route.page)
    const post = this.props.route.page.data
    return (
      <div className="markdown">
        <h1>{post.title}</h1>
        <div dangerouslySetInnerHTML={{ __html: post.body }}/>
      </div>
    )
  },
})

@KyleAMathews
Copy link
Contributor

An action item here would be to add a check in Gatsby if the necessary wrapper exists and if not, throw a very clear error.

@kristofferh
Copy link
Contributor Author

Ah, yeah, that works (minus the {data.title} part in your example). Thanks! It's not totally clear that you have to add your own wrapper, perhaps updating the examples would be a good idea? Either way, I'm closing this :)

@KyleAMathews
Copy link
Contributor

Oops on the data.title (fixed that above).

Yeah, I removed wrappers from core a while ago but it is super confusing when they're missing. I might add them back and improve documentation around what wrappers are and how to override them (which most projects will want to.

That or ensure all the official starters have included "starter" wrappers for each supported content type e.g. md, html, and soon toml, yaml, and json.

ChristopherBiscardi pushed a commit to ChristopherBiscardi/gatsby that referenced this issue Jun 9, 2019
ChristopherBiscardi pushed a commit to ChristopherBiscardi/gatsby that referenced this issue Jun 27, 2019
johno pushed a commit to johno/gatsby that referenced this issue Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@KyleAMathews @kristofferh and others