Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby@2.22.13+]: broken Typescript typings #24645

Closed
le0nik opened this issue May 30, 2020 · 1 comment · Fixed by #24769
Closed

[gatsby@2.22.13+]: broken Typescript typings #24645

le0nik opened this issue May 30, 2020 · 1 comment · Fixed by #24769
Assignees
Labels
status: needs core review Currently awaiting review from Core team member type: bug An issue or pull request relating to a bug in Gatsby

Comments

@le0nik
Copy link

le0nik commented May 30, 2020

Description

Typescript typings got broken after upgrading gatsby from 2.22.12 to 2.22.13

Probably related PR: #22504 .

Steps to reproduce

build gatsby project with typescript without --skipLibCheck

Expected result

No build errors

Actual result

node_modules/gatsby/index.d.ts:14:27 - error TS2307: Cannot find module './src/bootstrap/load-plugins/types' or its corresponding type declarations.

14 import { PluginRef } from "./src/bootstrap/load-plugins/types"

Environment

  System:
    OS: macOS 10.15.4
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
    Shell: 5.8 - /usr/local/bin/zsh
  Binaries:
    Node: 14.3.0 - ~/.nvm/versions/node/v14.3.0/bin/node
    Yarn: 1.22.4 - ~/.nvm/versions/node/v14.3.0/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v14.3.0/bin/npm
  Languages:
    Python: 3.8.0 - /Users/leo/.pyenv/shims/python
  Browsers:
    Chrome: 83.0.4103.61
    Firefox: 76.0
    Safari: 13.1
  npmPackages:
    gatsby: 2.22.13 => 2.22.13 
    gatsby-plugin-layout: 1.3.2 => 1.3.2 
    gatsby-plugin-lodash: 3.3.2 => 3.3.2 
    gatsby-plugin-material-ui: 2.1.9 => 2.1.9 
    gatsby-plugin-nprogress: 2.3.2 => 2.3.2 
    gatsby-plugin-postcss: 2.3.2 => 2.3.2 
    gatsby-plugin-react-redux: 1.1.0-0 => 1.1.0-0 
    gatsby-plugin-robots-txt: 1.5.1 => 1.5.1 
    gatsby-plugin-typescript: 2.4.3 => 2.4.3 
    gatsby-plugin-typography: 2.5.2 => 2.5.2 
    gatsby-source-filesystem: 2.3.8 => 2.3.8 
    gatsby-transformer-json: 2.4.3 => 2.4.3 

tsconfig.json

{
  "compilerOptions": {
    "baseUrl": ".",
    "lib": ["esnext", "dom"],
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "node",
    "noEmit": true,
    "strict": true,
    "allowSyntheticDefaultImports": true,
    "isolatedModules": true,
    "allowJs": true,
    "esModuleInterop": true,
    "disableSizeLimit": true,
    "jsx": "preserve"
  },
  "include": ["."],
  "exclude": ["node_modules", "public", ".cache", "data", "static"]
}
@le0nik le0nik added the type: bug An issue or pull request relating to a bug in Gatsby label May 30, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 30, 2020
@le0nik le0nik changed the title [gatsby@2.22.13]: broken Typescript typings [gatsby@2.22.13+]: broken Typescript typings May 31, 2020
@madalynrose madalynrose added status: needs core review Currently awaiting review from Core team member topic: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 1, 2020
@hasparus
Copy link
Contributor

I have the same problem with IPluginInfoOptions in gatsby ^2.24.82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs core review Currently awaiting review from Core team member type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants