chore(gatsby): Update load-plugins to Typescript. #22504
Conversation
Eyas
force-pushed
the
ts/gatsby-bootstrap
branch
from
2c7fffb to
e98db1c
Compare
Eyas
force-pushed
the
ts/gatsby-bootstrap
branch
2 times, most recently
from
2802d0f to
94919b3
Compare
|
@gatsbyjs/core friendly ping on this -- can someone take a look at this chore PR? |
|
@Eyas Thanks for the PR and sorry for the delay! We've got a lot going on! This PR is pretty outdated now and has several conflicts. Could you resolve them and then I'll prioritize reviewing and get this merged! |
blainekasten
added
the
status: awaiting author response
|
@blainekasten done. I'm having issues bootstrapping my local env (I'm on windows at the moment), but I'm happy to push follow-up fixes if anything is off. |
|
@blainekasten can you review #24519 first? The Babel typescript transform is producing confused imports of resolve-module-exports, causing some integration tests to misbehave. |
|
@Eyas merged that other PR! Let's get this one caught up and ready to merge! |
Eyas
added
status: awaiting reviewer response
|
@blainekasten Rebased and pushed. |
|
Lint failure is due to new blog post :( I also sent #24543 |
This ensure's Gastby's typings are consistent with reality.
|
@blainekasten Ready for review :) the linked issue got fixed. |
|
On it! |
blainekasten
added
bot: merge on green
* chore(gatsby): Update load-plugins to Typescript. * define gastsby typings in terms of actual types This ensure's Gastby's typings are consistent with reality. * Update yarn.lock * Apply lint fixes for validate.ts. * Typecheck fix. * Fix typecheck issues. * Typecheck fix. * Update tests to TS and Fix them. * Cast validate.ts use of resolveModuleExports
Description
This PR migrates
packages/gatsby/src/bootstrap/load-pluginsto TypeScript.Related Issues
Part of #21995.