Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress version in "End-to-End Testing" page #36097

Closed
2 tasks done
gh640 opened this issue Jul 11, 2022 · 6 comments · Fixed by #36204
Closed
2 tasks done

Cypress version in "End-to-End Testing" page #36097

gh640 opened this issue Jul 11, 2022 · 6 comments · Fixed by #36204
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@gh640
Copy link
Contributor

gh640 commented Jul 11, 2022 •
edited by LekoArts
Loading

Preliminary Checks

Summary

The current latest version of Cypress is 10.x. 10.0.0 was released at Jun 02, 2022.

The current description in "End-to-End Testing" doc page is correct for Cypress 9.x but incorrect for Cypress 10.x. It's better to mention the target version (9.x) or to update the page for Cypress 10.x.

The migration guide from 9.x to 10.x:

Steps to Resolve this Issue

  1. Update the linked doc page to show how Cypress is used in Version 10
  2. Update the linked example (https://github.com/gatsbyjs/gatsby/tree/master/examples/using-cypress) to Version 10, too
@gh640 gh640 added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jul 11, 2022
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 11, 2022
@LekoArts LekoArts added help wanted Issue with a clear description that the community can help with. good first issue Issue that doesn't require previous experience with Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 12, 2022
@LekoArts
Copy link
Contributor

LekoArts commented Jul 12, 2022 •
edited
Loading

Feel free to put up a PR updating the page + example to version 10 👍

@shikhar13012001
Copy link

I would like to work on this issue @LekoArts

@manthony9
Copy link

@gh640 @LekoArts is this issue just for the documentation update or does it include the actual migration too ?

@LekoArts
Copy link
Contributor

It would be updating both the page and example (see "Steps to resolve this issue")

@nodebotanist
Copy link
Contributor

I've got the upgrade working and I should have a PR by EOD today 7/21

nodebotanist added a commit to nodebotanist/gatsby that referenced this issue Jul 21, 2022
@nodebotanist
Upgraded Cypress to Version 10 (fixes gatsbyjs#36097)
0cf7e89
@nodebotanist nodebotanist mentioned this issue Jul 21, 2022
Merged
LekoArts added a commit that referenced this issue Jul 25, 2022
@nodebotanist @LekoArts
chore(docs): Upgrade Cypress to v10 in E2E Testing (#36204)
79036b3 
* Upgraded Cypress to Version 10 (fixes #36097)

* Added chonges to example

* we -> you

* Update end-to-end-testing.md

* fix example

Co-authored-by: Lennart <lekoarts@gmail.com>
@nodebotanist
Copy link
Contributor

We can close this, the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): Upgrade Cypress to v10 in E2E Testing nodebotanist/gatsby
5 participants
@nodebotanist @gh640 @manthony9 @LekoArts @shikhar13012001