Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add Lifecycle Sequence, and then Diagrams #6197

Closed
swyxio opened this issue Jun 28, 2018 · 8 comments · Fixed by #6229
Closed

[docs] add Lifecycle Sequence, and then Diagrams #6197

swyxio opened this issue Jun 28, 2018 · 8 comments · Fixed by #6229
Assignees
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@swyxio
Copy link
Contributor

swyxio commented Jun 28, 2018

Summary

The current Lifecycle APIs docs page is pretty sparse. The Reference/Node APIs are autogenerated from jsdoc which is SWEET because it is likely to be up to date, but not so sweet because it is in alphabetical rather than chronological order. Also its not clear what are "major" lifecycles and what are less important.

I wrote up this gist from my own investigations, but it would probably make sense to have this in the docs somewhere as people found it useful for bug tracking/plugin creation.

Decisions to make, assuming we want this in the docs:

  1. I think it would make sense to just put up and iterate on an all-text sequence, and then eventually make charts once we agree how best to represent this?

  2. The other big choice to make is autogeneration vs manual maintenance. I suspect it may take more effort to do the former than the latter.

btw: please tell me if these kinds of open/discussiony issues are welcome, I'm actually not sure since this channel is also for bugs and stuff.

@pieh pieh added help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Jun 28, 2018
@KyleAMathews
Copy link
Contributor

Very helpful! We definitely want to do this so appreciate you kicking off a discussion. /cc @kkemple @shannonbux

@kkemple
Copy link
Contributor

kkemple commented Jun 28, 2018

Yeah this is very much aligned with what we are already planning! for me, I would personally prefer to use manual vs auto-generated for many of the reasons you mentioned, but also because docs like that do fit under API references but are a bit cold for guide type docs.

I will take a look at your gist today and I love the idea of just getting a PR up and then just iterate until we are happy and then build any visualizations off of that. Would love to eventually get to something like this:

screen shot 2018-06-28 at 2 02 22 pm

@kkemple kkemple self-assigned this Jun 28, 2018
@shannonbux
Copy link
Contributor

Yes, very interested in this because I'd say it is one of the most common questions about Gatsby: "what is Gatsby?"
"what is Gatsby doing under the hood?"
"how does Gatsby work?"

So I know those are big questions! People want this!

@swyxio
Copy link
Contributor Author

swyxio commented Jun 28, 2018

well I can put in a few words then and we can slowly add to that. I think the problem with this kind of thing is its a deep, deep rabbit hole. the more detail people want, they more they basically just have to go through the source code. so we have to strike a balance somehow.

(concurrently I also think the console output itself needs to be redesigned.. which will make -this- effort a lot easier)

@m-allanson
Copy link
Contributor

I love the idea of just getting a PR up and then just iterate

👍 to this

concurrently I also think the console output itself needs to be redesigned..

and 👍 to this!

@swyxio
Copy link
Contributor Author

swyxio commented Jun 28, 2018

sorry I know I come up with a lot of ideas for work. I will try to pr some things to balance it.

@KyleAMathews
Copy link
Contributor

Adding this tweet to the conversation https://twitter.com/sebmarkbage/status/1012157736753098752?s=19

swyxio added a commit to swyxio/gatsby that referenced this issue Jun 29, 2018
@tsiq-swyx
Copy link
Contributor

wrote out some stuff, please edit if factually incorrect but this is my judgment of balance between detail vs keeping it high level.

m-allanson pushed a commit that referenced this issue Jul 4, 2018
* first attempt at lifecycle sequence docs

closes #6197

* address Kyle's review

I hope this is right...

* address Shannon's comments

address Shannon's comments
m-allanson pushed a commit that referenced this issue Jul 4, 2018
* first attempt at lifecycle sequence docs

closes #6197

* address Kyle's review

I hope this is right...

* address Shannon's comments

address Shannon's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants