Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[www] Showcase: Fix Showcase header position:sticky #6202

Closed
fk opened this issue Jun 28, 2018 · 0 comments · Fixed by #6203
Closed

[www] Showcase: Fix Showcase header position:sticky #6202

fk opened this issue Jun 28, 2018 · 0 comments · Fixed by #6203
Assignees
@fk

Comments

@fk
Copy link
Contributor

fk commented Jun 28, 2018

Current top for position:sticky doesn't take the "banner" height into account:

image

gatsby/www/src/pages/showcase.js

Line 966 in 5dfd4d3

top: `calc(${presets.headerHeight} - 1px)`,

@fk fk self-assigned this Jun 28, 2018
fk added a commit to fk/gatsby that referenced this issue Jun 28, 2018
@fk
Fix Showcase header position:sticky top
0b45ec8 
…and sidebar height, fixes gatsbyjs#6202
@fk fk mentioned this issue Jun 28, 2018
Merged
m-allanson pushed a commit that referenced this issue Jun 28, 2018
@fk @m-allanson
Fix Showcase header position:sticky top (#6203)
02a0f40 
…and sidebar height, fixes #6202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fk fk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[www] Showcase: Fix header position:sticky top fk/gatsby
1 participant
@fk