-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix references to react-helmet usage #11690
Conversation
Update references to `react-helmet`- 1. Update link to `package-readme.js` because `layout.js` is not using `react-helmet` anymore. 2. Remove reference to `Jason Lengstorf’s personal website` because it's to using react-helmet package
@jlengstorf does your site not use react-helmet anymore? I see some references to it in your rendered site, but not in the source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: oops I wrote this comment and then didn't post it until the next day. 😬 So didn't see Marcy's comment until just now.
Thanks @gurpreet-hanjra 👍
@jlengstorf recently updated his site to use Gatsby themes. So his usage of react-helmet
can be found over here: https://github.com/jlengstorf/gatsby-theme-jason-blog/blob/master/src/components/SEO/SEO.js
Maybe linking to the seo component in the default starter could be handy too? https://github.com/gatsbyjs/gatsby/blob/master/starters/default/src/components/seo.js
1. add reference to default starter 2. add reference Jason's blog
Thank you @m-allanson . Changes are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @m-allanson said. 😄
This looks good to me. I'll let @marcysutton do the final approval, though.
@marcysutton waiting for your final approval :) |
Update references to
react-helmet
-package-readme.js
becauselayout.js
is not usingreact-helmet
anymore.Jason Lengstorf’s personal website
because it's not using react-helmet packageDescription
Related Issues