do not merge - just testing something #12763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
reviewed
Mar 22, 2019
| @@ -50,6 +50,7 @@ aliases: | |||
| test_template: &test_template | |||
| steps: | |||
| - checkout | |||
| - run: node -v | |||
There was a problem hiding this comment.
😬 hopefully the executors are working like we'd expect! Good idea.
|
This is just to test something that came up in #12719 - because according to info there - it should fail for node6 (as some module is node8+ only), but it passed there :S |
|
It reports expected node version - so not sure why test in PR linked above doesn't fail in some ways if it needs node 8+ stuff - hmm, let's check something more |
|
@pieh that package could be following our approach, haha. e.g. "soft deprecating" but still supporting? |
|
That's also possible. Maybe just parts of the package that we use might not require 8+? |
|
Ok, so tests that is designed to fail in node 6 and pass in node 8+ works - so our tests doesn't seem to be wonky after all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just for testing purposes - I will close this later