-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fancy Javascript Example #1492
Fancy Javascript Example #1492
Conversation
Deploy preview failed. Built with commit 0c41941 https://app.netlify.com/sites/using-styled-components/deploys/59680c6d8ebdd92e9118924a |
Deploy preview ready! Built with commit 0c41941 |
Deploy preview ready! Built with commit 0c41941 |
Deploy preview ready! Built with commit 0c41941 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
Could you change the name of the site to something more "boring" but descriptive e.g. using-javascript-frontmatter
. That'll make the site more discoverable.
examples/fancy-javascript/.babelrc
Outdated
@@ -0,0 +1,4 @@ | |||
{ | |||
"presets": ['react', 'es2015', 'stage-0'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the .eslintrc file shouldn't be necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gatsbygram had them so I figured I would include them. Can remove them though.
"bulma": "0.4.2", | ||
"d3": "4.9.1", | ||
"gatsby": "^1.1.0", | ||
"gatsby-link": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of these plugins don't have a 1.1.0 release yet — Lerna doesn't make a new release for a package unless there's been changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I was wondering, yarn makes it to easy to ignore this fact.
So my expectation with this example is to showcase any plugin/transformer/etc. that deals directly with javascript. For now, it is just frontmatter, yes. But as we add more js stuff, I would presume that it will be a little bit more complicated then say, markdown, to compose and it feels like it would be nice have an example documenting how they interact / work together. (I mostly showcased the markdown as an addition to this as it is painful to write directly in javascript, and the convenience of markdown I presume will make it a very typical pair.) That being said, I am not opposed to a name change, but I think it would be worthwhile to keep it a little bit more... general I guess? What are your thoughts? |
So right now we have three types of example sites — full-blown applications like gatsbygram, very small plugin example sites, and one "ecosystem" example site https://using-remark.gatsbyjs.org/ I can see this site also becoming a kind of "ecosystem" site. If that's your goal, perhaps name the site "using-javascript-transforms"? |
Yea, definitely, that sounds perfect to me! |
I think that covers everything. |
Awesome! Thanks so much Jacob! |
Hey just tried building this on Netlify and got this error:
Could you look into it and PR a fix? |
Will do! |
There is still stuff I could add (especially to the README), but wanted to get this out before I had to jump back to paid work. I tried to comment the files themselves well at least.