Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported method in IE #1573

Merged
merged 2 commits into from
Jul 20, 2017
Merged

Fix unsupported method in IE #1573

merged 2 commits into from
Jul 20, 2017

Conversation

variadicintegrity
Copy link
Contributor

The dev server fails in IE 11 with this message:

Object doesn't support property or method 'find'

Referencing the Array.prototype.find call.
This method isn't supported in IE.

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview ready!

Built with commit 3fb7a43

https://deploy-preview-1573--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview failed.

Built with commit 3fb7a43

https://app.netlify.com/sites/gatsbygram/deploys/5970883e7960b14f957a2d44

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2017

Deploy preview ready!

Built with commit 3fb7a43

https://deploy-preview-1573--gatsbyjs.netlify.com

@KyleAMathews
Copy link
Contributor

Could you run npm run format from the root of the repo?

@KyleAMathews
Copy link
Contributor

Thanks for the fix!

@KyleAMathews KyleAMathews merged commit 41c75b2 into gatsbyjs:master Jul 20, 2017
KyleAMathews pushed a commit that referenced this pull request Jul 20, 2017
…1574)

* Removes the slash between the `pathPrefix` and `pathname` when navigating - this bug was introduced by (#1550)

* Fix unsupported method in IE (#1573)

* Fix unsupported method in IE

* Fix formatting

* Don't set a default title in html.js as not overriden by react-helmet (#1578)

* Downgrade Glamor to v2 as v3 unstable (#1580)

* Downgrade Glamor to v2 as v3 unstable

* Fixes

* Fix other PR

* Remove replace
This was referenced Mar 16, 2018
@jlengstorf
Copy link
Contributor

Hiya @variadicintegrity! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants