Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Serialize override to the docs #1681

Conversation

chiedo
Copy link

@chiedo chiedo commented Aug 1, 2017

No description provided.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 30241ae

https://deploy-preview-1681--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 30241ae

https://deploy-preview-1681--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 30241ae

https://deploy-preview-1681--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 77fa0f0

https://deploy-preview-1681--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 77fa0f0

https://deploy-preview-1681--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 77fa0f0

https://deploy-preview-1681--gatsbygram.netlify.com

@secretfader
Copy link

👍 Thanks for this.

@KyleAMathews
Copy link
Contributor

Looks great!

BTW, @nicholaswyoung it's not altogether clear to me how the top-level query and feeds queries relate to each other.

@KyleAMathews KyleAMathews merged commit dd75783 into gatsbyjs:master Aug 1, 2017
@secretfader
Copy link

secretfader commented Aug 2, 2017

@KyleAMathews For future documentation...

My thinking was options.query is effectively a global and is executed once per plugin iteration. feeds[].query is feed-local. Any data returned by feeds[].query is merged the data produced by options.query. Local data has priority.

This setup, while it may be a bit tricky at first, ultimately allows maximum reconfigurability and performance. I designed it when creating multiple (and rather complex) podcast feeds for my site. It's likely that I'll keep refining the API to improve it over time as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants