Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-image): Clarify IntersectionObserver support in README.md #16962

Merged
merged 2 commits into from
Aug 23, 2019
Merged

chore(gatsby-image): Clarify IntersectionObserver support in README.md #16962

merged 2 commits into from
Aug 23, 2019

Conversation

bjfresh
Copy link
Contributor

@bjfresh bjfresh commented Aug 22, 2019

The latest Safari releases for Desktop and iOS now include support for IntersectionObserver:
https://caniuse.com/#feat=intersectionobserver

Description

Documentation edits gatsby-image

Related Issues

The latest Safari releases for Desktop and iOS now include support for IntersectionObserver:
https://caniuse.com/#feat=intersectionobserver
@bjfresh bjfresh requested a review from a team as a code owner August 22, 2019 13:38
@lannonbr
Copy link
Contributor

I'm curious if it is needed to comment for people using older versions of safari given the quick turnaround of people upgrading to new versions of MacOS & iOS. For instance here on Apple's App Store support site, about 88% of people on iOS are running at least iOS 12 now. So if there's less and less people on these older versions of iOS / MacOS, should we need to say this for older versions or just comment that if you are supporting IE that you need polyfills

@bjfresh
Copy link
Contributor Author

bjfresh commented Aug 22, 2019

I weighed both options, figuring that a March 2019 release was recent enough to warrant the specificity, especially given that there's just 88% support for IntersectionObserver globally. Of course, that'll fade quickly. According to the stats, 3% are still using incompatible versions of Safari. Realistically it's probably enough to simply encourage people to check browser support, and highlight IE as an outlier.

@wardpeet
Copy link
Contributor

I agree with @lannonbr if we can just drop Safari that would be great :)

Remove specific Safari versions from note on IntersectionObserver compatibility
@lannonbr lannonbr changed the title Clarify IntersectionObserver support in README.md chore(gatsby-image): Clarify IntersectionObserver support in README.md Aug 22, 2019
@lannonbr lannonbr added the topic: media Related to gatsby-plugin-image, or general image/media processing topics label Aug 22, 2019
@bjfresh
Copy link
Contributor Author

bjfresh commented Aug 23, 2019

OK, done. Safari is out.

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@wardpeet wardpeet merged commit 41d3e1c into gatsbyjs:master Aug 23, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 23, 2019

Holy buckets, @bjfresh — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants