-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby-image): Clarify IntersectionObserver support in README.md #16962
Conversation
The latest Safari releases for Desktop and iOS now include support for IntersectionObserver: https://caniuse.com/#feat=intersectionobserver
I'm curious if it is needed to comment for people using older versions of safari given the quick turnaround of people upgrading to new versions of MacOS & iOS. For instance here on Apple's App Store support site, about 88% of people on iOS are running at least iOS 12 now. So if there's less and less people on these older versions of iOS / MacOS, should we need to say this for older versions or just comment that if you are supporting IE that you need polyfills |
I weighed both options, figuring that a March 2019 release was recent enough to warrant the specificity, especially given that there's just 88% support for IntersectionObserver globally. Of course, that'll fade quickly. According to the stats, 3% are still using incompatible versions of Safari. Realistically it's probably enough to simply encourage people to check browser support, and highlight IE as an outlier. |
I agree with @lannonbr if we can just drop Safari that would be great :) |
Remove specific Safari versions from note on IntersectionObserver compatibility
OK, done. Safari is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Holy buckets, @bjfresh — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
The latest Safari releases for Desktop and iOS now include support for IntersectionObserver:
https://caniuse.com/#feat=intersectionobserver
Description
Documentation edits gatsby-image
Related Issues