Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup for how custom classes in remark could work #1736

Closed
wants to merge 1 commit into from

Conversation

Algram
Copy link
Contributor

@Algram Algram commented Aug 6, 2017

The idea is brought over from markdown-it. They do it the same way and I find it really intuitive. Also you do not have to write custom html into markdown.

The idea is brought over from markdown-it. They do it the same way and I find it really intuitive. Also you do not have to write custom html into markdown.
@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 7e9337c

https://deploy-preview-1736--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 7e9337c

https://deploy-preview-1736--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

This syntax looks great but would require a new Remark/Gatsby plugin to add support. Looking around I didn't see anything so it'd probably need written from scratch. We'd also need to add support for this sort of thing to gatsby-remark-images as that rewrites the image HTML to support its blur-up & responsive image placeholder features.

Thanks for sharing the mockup of what syntax you'd like. As there's quite a bit more work that'd be needed done to support this + probably more discussion needed on the best way to support adding classes & other attributes to markdown I'll close this PR and if you could follow up with an issue with more research on options that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants