Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad character escape sequence in typography.js on Windows #1801

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

JGameCreation
Copy link
Contributor

Fixes the issue discussed here lately: #1669
This replace single backslashes on windows with double backslashes. Without this the following error occurs on Windows machines:

Error: Module parse failed: C:\src\node_modules\gatsby-plugin-typography.cache\typography.js Bad character escape sequence (1:56) You may need an appropriate loader to handle this file type. SyntaxError: Bad character escape sequence (1:56)

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 14, 2017

Deploy preview ready!

Built with commit f5a1a1b

https://deploy-preview-1801--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 14, 2017

Deploy preview ready!

Built with commit f5a1a1b

https://deploy-preview-1801--gatsbygram.netlify.com

@JGameCreation
Copy link
Contributor Author

Could someone please explain to me why the checks failed? This was my first commit and I have no idea.

@KyleAMathews
Copy link
Contributor

@JGameCreation woah nice fix! This looks like what we need to do for #1783 as well! @bskimball

On failing stuff — you jumped in the Gatsby waters during a bit of unstability. PRs are in progress/done with fixes. I'll finish those and merge them into this PR.

Thanks again!

@KyleAMathews KyleAMathews merged commit 5fd80aa into gatsbyjs:master Aug 14, 2017
@kylegalbraith
Copy link
Contributor

Wow beat me to it @JGameCreation! A million thank yous.

@jlengstorf
Copy link
Contributor

Hiya @JGameCreation! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants