-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate CLI logic and depend on it in gatsby #1880
Conversation
Deploy preview failed. Built with commit dc991d0 https://app.netlify.com/sites/using-glamor/deploys/599c97f30752d03e0da58547 |
Deploy preview failed. Built with commit 2e82b02 https://app.netlify.com/sites/using-glamor/deploys/599e04607960b15febf434db |
On quick read through looks great! Love your refactors :-) I'll test the PR manually in the morning to make sure nothing is broken. Also looks like the yarn.lock got deleted. |
oops on the yarn lock let me fix that |
Oooo and you fixed up |
Only thing I saw missing was |
This reverts commit 2a6d803.
I think this is done, its a bit hard to test. wouldn’t say no to some more eyes on it :)