-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(setting-up-your-local-dev-environment): beautify some parts #19349
Conversation
i feel the |
should we also add some notes about develop-runner - i only found this description here #19092 (review)
|
I'm not sure - we ourselves use this pretty rarely, only when there is rewrite of one of major core function that potentially could introduce bugs (or unforeseen breaking changes). Last time we used it (before schema rebuilding PR) was materialization for data layer. The script itself also takes a loong time to run, so I don't want to force it on contributors, as it's not needed for most of PRs. It makes sense to me to make a note about it somewhere, but this could be separate PR to not scope creep this one? |
Yes, if none of the |
So I can leaveThe watch part it as is? |
placed suggestion about |
This is looking really good. Love the additional details for such a popular write up. |
Co-Authored-By: LB <barth.laurie@gmail.com>
Co-Authored-By: LB <barth.laurie@gmail.com>
updated from suggestions of @laurieontech and @jbampton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better thanks 👍
:( CI test are failing - but there are out of my scope |
Also maybe you should update the PR description to remove |
done |
Description
gatsby-cli
andgatsby-dev-cli
- add a hint aboutremoved by requestPull Bot
Related Issues
n/a
Wordings
i am not good in wording docs, suggestions are welcome