Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix test ignore patterns #19847

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

mareksuscak
Copy link
Contributor

@mareksuscak mareksuscak commented Nov 28, 2019

Description

The recommended test ignore patterns hit us hard recently b/c our project had the word public in the repository name on GitHub so basically when our CI cloned the repository and ran jest, it wouldn't find any files. We spent a good number of hours investigating why it wasn't working only to find out that jest was ignoring all of the files due to the fact that the word public was causing an entire project folder to be excluded.

Related Issues

@mareksuscak mareksuscak requested a review from a team as a code owner November 28, 2019 00:02
docs/docs/unit-testing.md Outdated Show resolved Hide resolved
@LekoArts LekoArts changed the title Fix test ignore patterns chore(docs): Fix test ignore patterns Jan 8, 2020
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 8, 2020
@LekoArts LekoArts merged commit cb66da1 into gatsbyjs:master Jan 8, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2020

Holy buckets, @mareksuscak — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@mareksuscak mareksuscak deleted the patch-1 branch January 8, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants