Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-hacker-news): use schema customization API #20070

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Dec 11, 2019

Description

Start using schema customization API for gatsby-source-hacker-news

Documentation

N/A. Will be probably a separate PR with recipes after #20069

Related Issues

Part of #20069

@vladar vladar requested review from a team as code owners December 11, 2019 13:39
freiksenet
freiksenet previously approved these changes Dec 12, 2019
@freiksenet freiksenet self-requested a review December 12, 2019 07:18
@pieh
Copy link
Contributor

pieh commented Dec 12, 2019

I think we need to bump https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-source-hacker-news/package.json#L28 to whatever version @childOf directive was added?

@vladar
Copy link
Contributor Author

vladar commented Dec 12, 2019

Right! It was first introduced in 2.13.28. @pieh I guess we should publish this as a minor then?

@vladar vladar merged commit e993369 into master Dec 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the vladar/gh-20069-hacker-news branch December 16, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants