chore(gatsby): Add TS support to eslint and improve speed #20246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
added
the
type: maintenance
blainekasten
commented
Dec 20, 2019
blainekasten
commented
Dec 20, 2019
blainekasten
commented
Dec 20, 2019
blainekasten
commented
Dec 20, 2019
LekoArts
previously requested changes
Jan 7, 2020
| "no-console": "off", | ||
| "no-inner-declarations": "off", | ||
| "prettier/prettier": "error", | ||
| quotes: ["error", "backtick"], |
There was a problem hiding this comment.
We might wanna change this line to something I use in my TS repo with backticks:
https://github.com/LekoArts/gatsby-themes/blob/master/.eslintrc.js#L47-L54
Reasoning: typescript-eslint/typescript-eslint#762
So ESLint otherwise wants to convert double quotes on types to backticks and the TS compiler doesn't like that at all!
sidharthachatterjee
added
the
bot: merge on green
sidharthachatterjee
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--cacheflagnode_modulesinside of packages.Previously we were telling eslint to ignore files from our .gitignore and .prettierignore. This was pragmatic and clever but did not work quite as well as it should have.
For 1, it was ignoring some files that should not have been ignored, and 2 eslint was parsing node_modules in the packages. This was leading to really slow lint times.
Having a dedicated
.eslintignorefile is, unfortunately, another file to maintain, however it is explicitly declarative and allows us more granular control.