fix(gatsby-starter-blog): Load PrismJS theme CSS #20282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently this starter includes
gatsby-remark-prismjs
but doesn't load a theme for it. Loading a theme is considered a requirement by gatsby-remark-prismjs, since without one syntax highlighting doesn't work properly. This causes confusion for new users.This PR loads the 'Coy' theme, which I think fits in nicely with the aesthetic of the starter.
I'm not sure if this starter is meant to be as minimal as possible or if it's meant to provide a best-practices starting point. If the latter, I think we should also include the line highlighting styles, line numbering styles, and fancy shell prompt. These don't require any additional NPM dependencies, but they do slightly increase the footprint of each page. I'm happy to also add these to the starter if people think it's a good idea.
Documentation
I don't believe there's any documentation required here. If we decide not to add the optional styles then maybe we should include a note about them in the instructions.