Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-starter-blog): Load PrismJS theme CSS #20282

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

YoshiWalsh
Copy link
Contributor

Description

Currently this starter includes gatsby-remark-prismjs but doesn't load a theme for it. Loading a theme is considered a requirement by gatsby-remark-prismjs, since without one syntax highlighting doesn't work properly. This causes confusion for new users.

This PR loads the 'Coy' theme, which I think fits in nicely with the aesthetic of the starter.

I'm not sure if this starter is meant to be as minimal as possible or if it's meant to provide a best-practices starting point. If the latter, I think we should also include the line highlighting styles, line numbering styles, and fancy shell prompt. These don't require any additional NPM dependencies, but they do slightly increase the footprint of each page. I'm happy to also add these to the starter if people think it's a good idea.

Documentation

I don't believe there's any documentation required here. If we decide not to add the optional styles then maybe we should include a note about them in the instructions.

@YoshiWalsh YoshiWalsh requested a review from a team as a code owner December 24, 2019 01:33
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I changed the commonJS import and used the default Prism theme.

@LekoArts LekoArts changed the title Load PrismJS theme CSS fix(gatsby-starter-blog): Load PrismJS theme CSS Jan 8, 2020
@LekoArts LekoArts merged commit 2de9617 into gatsbyjs:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants