Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-sharp): define required image fields as non-null in schema #20314

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

daugsbi
Copy link
Contributor

@daugsbi daugsbi commented Dec 27, 2019

Description

The generated graphql schema have a lot of nullable fields which are required for images (i.e. the src of an image). This makes it incompatible to use it with type generators and TypeScript.

This PR changes the gatsby-source-contentful and the gatsby-transformer-sharp to be at least compatible with the gatsby-image type definitions.

Documentation

Docs should exist already. I don't expect that they include such details.

Related Issues

This PR should close #17003.

@daugsbi daugsbi requested a review from a team as a code owner December 27, 2019 18:03
@pvdz pvdz requested a review from blainekasten January 6, 2020 11:41
@pvdz pvdz removed the request for review from blainekasten January 6, 2020 11:41
Kerumen
Kerumen previously approved these changes Jan 7, 2020
Copy link
Contributor

@Kerumen Kerumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion! It makes perfect sense. Left one request for a change (minor change for consistency). Then we are good to go!

packages/gatsby-transformer-sharp/src/customize-schema.js Outdated Show resolved Hide resolved
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, thanks for the PR!

@vladar vladar changed the title Fix schema to represent required image fields fix(gatsby-transformer-sharp): define required image fields as non-null in schema Jan 8, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 8, 2020
@gatsbybot gatsbybot merged commit e3026c9 into gatsbyjs:master Jan 8, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2020

Holy buckets, @daugsbi — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-image] Bad schema typing for gatsby-images ?
5 participants