Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add Stripe reference guide #20347

Merged
merged 10 commits into from
Jan 16, 2020
Merged

chore(docs): Add Stripe reference guide #20347

merged 10 commits into from
Jan 16, 2020

Conversation

connorlindsey
Copy link
Contributor

Description

Close issue #20199 by adding reference guide for Stripe. Also updated the doc-links to include the guide under building an e-commerce site.

Related Issues

Closes #20199

@connorlindsey connorlindsey requested review from a team as code owners December 30, 2019 17:17
@LekoArts LekoArts changed the title [docs][guide] Add Stripe reference guide - close #20199 chore(docs): Add Stripe reference guide Jan 8, 2020
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 8, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @connorlindsey! Thank you so much for writing this and for your patience while the team was out over the holidays. I have some suggestions and would love to hear your thoughts.

docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Outdated Show resolved Hide resolved
docs/docs/process-payments-with-stripe.md Show resolved Hide resolved
connorlindsey and others added 7 commits January 8, 2020 13:51
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Co-Authored-By: Michael <184316+muescha@users.noreply.github.com>
Co-Authored-By: Aisha Blake <aisha.g.blake@gmail.com>
Copy link
Contributor Author

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the awesome feedback. I'll make those changes.

Added prerequisites section and made setting up the Stripe account and getting keys as H3s.
bball07
bball07 previously approved these changes Jan 16, 2020
Copy link
Contributor

@bball07 bball07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully walk through your steps! Thank you

Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Thanks for contributing this guide and incorporating all that feedback!

@AishaBlake AishaBlake added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 16, 2020
@gatsbybot gatsbybot merged commit 90c0532 into gatsbyjs:master Jan 16, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 16, 2020

Holy buckets, @connorlindsey — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][guides] New Reference Guide on working with Stripe
6 participants