Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #20353

Merged
merged 6 commits into from
Jan 8, 2020
Merged

Fix some typos #20353

merged 6 commits into from
Jan 8, 2020

Conversation

SinithH
Copy link
Contributor

@SinithH SinithH commented Dec 30, 2019

Description

fixed a typo

Documentation

Related Issues

@SinithH SinithH requested a review from a team as a code owner December 30, 2019 18:57
amandeepmittal
amandeepmittal approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SinithH
Copy link
Contributor Author

SinithH commented Jan 2, 2020

LGTM!

Whats's the status of this PR ?

@DanielRuf
Copy link
Contributor

Whats's the status of this PR ?

Please keep in mind that most of the team are in holidays at the moment. After the review the core maintainers will merge it when they find the needed time.

@DanielRuf DanielRuf changed the title fixed a typo Fix some typos Jan 2, 2020
@DanielRuf
Copy link
Contributor

from SinithH:master

Please use a separate branch next time to prevent conflicts. Pushing from the master branch is an anti-pattern.

sidharthachatterjee
sidharthachatterjee approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 8, 2020
@gatsbybot gatsbybot merged commit 6cfa002 into gatsbyjs:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandeepmittal amandeepmittal amandeepmittal approved these changes

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@daniloster daniloster daniloster approved these changes

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SinithH @DanielRuf @daniloster @sidharthachatterjee @amandeepmittal @gatsbybot