Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): fixes for the export drupal to gatsby post #20360

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

jackbravo
Copy link
Contributor

Thanks to https://www.drupal.org/u/klokie who sent some fixes and suggestions via email for this blog post:

  1. After git init, the next step should be npm install and then npm i --save-dev better-sqlite3.
  2. You mention that you named the script src/scripts/migrate.js, but refer
    to it afterward as src/scripts/import.js, so it should probably be named
    src/scripts/import.js.
  3. aliases is never defined - what should it be?

Description

Documentation

Related Issues

Thanks to https://www.drupal.org/u/klokie who sent some fixes and suggestions via email for this blog post:

1. After `git init`, the next step should be `npm install` and then `npm i
--save-dev better-sqlite3`.
2. You mention that you named the script `src/scripts/migrate.js`, but refer
to it afterward as `src/scripts/import.js`, so it should probably be named
`src/scripts/import.js`.
3. `aliases` is never defined - what should it be?
@jackbravo jackbravo requested a review from a team as a code owner December 30, 2019 23:34
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 8, 2020
@gatsbybot gatsbybot merged commit 4c8e23b into master Jan 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the jackbravo-patch-1 branch January 8, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants