Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-remark-autolink-headers): Scroll to document top #20363

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

Rikpat
Copy link
Contributor

@Rikpat Rikpat commented Dec 31, 2019

Description

Calculates scroll position in autolink-headers relative to document top instead of closest relative parent

Documentation

Related Issues

Fixes #20362

Fixed scroll position issues with relative parent for gatsby-remark-autolink-headers gatsby-browser.js
Fixed scroll position issues with relative parent for gatsby-remark-autolink-headers in gatsby-ssr.js
@Rikpat Rikpat requested a review from a team as a code owner December 31, 2019 15:01
@LekoArts LekoArts changed the title Fixed fix(gatsby-remark-autolink-headers): Scroll to top parent Jan 8, 2020
@LekoArts LekoArts changed the title fix(gatsby-remark-autolink-headers): Scroll to top parent fix(gatsby-remark-autolink-headers): Scroll to document top Jan 8, 2020
@LekoArts LekoArts added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Jan 8, 2020
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Also had issues like this in past. Tried it locally and works fine.

@vladar vladar added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Jan 9, 2020
@gatsbybot gatsbybot merged commit 1810254 into gatsbyjs:master Jan 9, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 9, 2020

Holy buckets, @Rikpat — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@Rikpat Rikpat deleted the patch-1 branch January 10, 2020 07:14
Rikpat added a commit that referenced this pull request Jan 29, 2020
Changed autolink headers offset because of changed scroll based on page position instead of container in #20363
gatsbybot pushed a commit that referenced this pull request Jan 29, 2020
Changed autolink headers offset because of changed scroll based on page position instead of container in #20363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-remark-autolink-headers doesn't work properly inside relatively positioned container
4 participants