feat(gatsby): Supports multiple development proxies #20369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloster
reviewed
Jan 2, 2020
| ) | ||
| .on(`error`, (err, _, response) => { | ||
| if (response) { | ||
| proxy.forEach(({prefix, url}) => { |
There was a problem hiding this comment.
What if only an object is set in the config?
Would still behave as an array?
There was a problem hiding this comment.
Object would be converted to array by joi array.single()
| url: Joi.string().required(), | ||
| }) | ||
| ) | ||
| .single(), |
There was a problem hiding this comment.
It might be my dev preference. Having a more specific type either array or object gives more predictability to the code execution. I would rather release it as a breaking change.
Having only:
proxy: Joi.array()
.items(
Joi.object().keys({
prefix: Joi.string().required(),
url: Joi.string().required(),
})
),
daniloster
previously approved these changes
Jan 3, 2020
|
Sorry taking long on this |
ThewBear
added
status: awaiting reviewer response
freiksenet
previously approved these changes
Jan 8, 2020
freiksenet
approved these changes
Jan 10, 2020
freiksenet
added
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes development proxy config accepts either an object or array of objects.
Documentation
https://www.gatsbyjs.org/docs/api-proxy/
Related Issues
#20366