Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-starter-help-center #20407

Merged
merged 2 commits into from
Jan 8, 2020
Merged

chore(starters): add gatsby-starter-help-center #20407

merged 2 commits into from
Jan 8, 2020

Conversation

dferber90
Copy link
Contributor

Description

Adds gatsby-starter-help-center to stater library.

You can find a live version and documentation website at help.dferber.de.

@dferber90 dferber90 requested a review from a team as a code owner January 3, 2020 20:26
amandeepmittal
amandeepmittal previously approved these changes Jan 4, 2020
@JimLynchCodes
Copy link
Contributor

JimLynchCodes commented Jan 4, 2020

hey, I'm not a real reviewer here- just a fellow author of gatsby starters who likes checking out new starters! 😃

Nice site @dferber90 !

  • The hosted site (https://help.dferber.de) looks nice! I was getting one error in the console though (on macOS chrome in the live site and when running it locally). You may want to check that out:
 (GET https://cdn.simpleanalytics.io/hello.js net::ERR_BLOCKED_BY_CLIENT) 
gatsby new test-gatsby-starter-help-center https://github.com/dferber90/gatsby-starter-help-center

Then I am able to run all of the npm commands with no issues. 👍

You could consider adding a .npmrc and / or .nvmrc to give a default recommended node version.
(I used v8.16.0)

  • tags are all valid categories

  • features make sense

You don't have any releases though for this repo on github. It would be nice to publish a 1.0 and have official releases so it's easier for users to track when you make updates the starter and what they entail.

One other comment I would have it that I'm not totally sure I know what you mean by "Help Center" so it would be nice to explain more about that in the README somewhere.

@dferber90
Copy link
Contributor Author

Thanks for your feedback @JimLynchCodes

The hosted site (https://help.dferber.de) looks nice! I was getting one error in the console though (on macOS chrome in the live site and when running it locally). You may want to check that out:

This happens because your ad blocker is blocking the request to the analytics plugin that comes with the starter. It's nothing to worry about and expected to happen.

One other comment I would have it that I'm not totally sure I know what you mean by "Help Center" so it would be nice to explain more about that in the README somewhere.

People who don't know what a help center is probably won't need this template in the first place. I can add an explanation in case people stumble upon it anyways, thanks for the hint 👍

You don't have any releases though for this repo on github. It would be nice to publish a 1.0 and have official releases so it's easier for users to track when you make updates the starter and what they entail.

There are no big changes or new features planned at the moment. When something major comes up, that sounds like a good way to do things!

@JimLynchCodes
Copy link
Contributor

@dferber90 Yep, you are right that is was the ad blocker! lgtm! 👍

freiksenet
freiksenet previously approved these changes Jan 7, 2020
@freiksenet freiksenet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 7, 2020
@LekoArts LekoArts dismissed stale reviews from freiksenet and amandeepmittal via 5cfe487 January 8, 2020 13:01
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the starter! You should absolutely convert this into a Gatsby theme:
https://www.gatsbyjs.org/docs/themes/what-are-gatsby-themes/

@LekoArts LekoArts merged commit 734496d into gatsbyjs:master Jan 8, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2020

Holy buckets, @dferber90 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants