Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update gatsby-cli ReadMe for develop PORT env var #20417

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

CollierCZ
Copy link
Contributor

Description

Updates defaults in gatsby-cli ReadMe to note the fallback to env.PORT if it is provided.

Related Issues

Updates reference not caught in #20250 and thus fixes #20214.

@CollierCZ CollierCZ requested a review from a team as a code owner January 5, 2020 10:38
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Jan 8, 2020
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 8, 2020
@gatsbybot gatsbybot merged commit 51d81e9 into master Jan 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the CollierCZ-patch-1 branch January 8, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation: update gatsby-cli docs to specify process.env.PORT usage
4 participants