Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update starters.yml #20418

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Update starters.yml #20418

merged 2 commits into from
Jan 7, 2020

Conversation

afc163
Copy link
Contributor

@afc163 afc163 commented Jan 5, 2020

Description

Documentation

Related Issues

@afc163 afc163 requested a review from a team as a code owner January 5, 2020 14:46
Ekwuno
Ekwuno suggested changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@Ekwuno Ekwuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @afc163. However, there is a list of approved tags that are available for starters. styling: less isn't on the list. This is causing the change to fail validation. Could you fix that?

@afc163
Copy link
Contributor Author

afc163 commented Jan 7, 2020

Fixed

@Ekwuno
Copy link
Contributor

Ekwuno commented Jan 7, 2020

Thanks, @afc163 .

@Ekwuno Ekwuno merged commit 9efb376 into gatsbyjs:master Jan 7, 2020
@afc163 afc163 deleted the patch-3 branch January 7, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekwuno Ekwuno Ekwuno requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afc163 @Ekwuno