Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starters): add gatsby-typescript-emotion-storybook #20440

Merged
merged 3 commits into from
Jan 8, 2020
Merged

chore(starters): add gatsby-typescript-emotion-storybook #20440

merged 3 commits into from
Jan 8, 2020

Conversation

duncanleung
Copy link
Contributor

Description

Adds gatsby-typescript-emotion-storybook to starter library.

Motivation

There isn't a well documented config to get Storybook to work with Gatsby + TypeScript + Emotion + React Intl + SVGR.

I was able to get the gatsby-config.js and /.storybook/webpack.config.js configuration set up, and wanted to this share the base starter config with the community.

@duncanleung duncanleung requested a review from a team as a code owner January 6, 2020 21:29
@duncanleung
Copy link
Contributor Author

Interesting. Not entirely sure why CI is failing on this starters.yml change.

CI is failing at the step:
yarn bootstrap -- concurrency=2

Error: Cannot find module '@babel/plugin-transform-typescript' from '/home/circleci/project/packages/gatsby-cli'

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@LekoArts LekoArts merged commit f40a25d into gatsbyjs:master Jan 8, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2020

Holy buckets, @duncanleung — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@duncanleung
Copy link
Contributor Author

Hi @LekoArts -

I updated the starter so that the landing page is more appealing.
Gatsby___TypeScript___Emotion___Storybook_Starter___Website

However, the Gatsby Starter Library screenshot is still the old design.
Starter_Library___GatsbyJS

Do I just need to wait for the next Gatsby build for this to be updated, or do I need to make a PR to see this update?

Thank you for your help.

@LekoArts
Copy link
Contributor

Eventually it'll update itself, you don't need to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants