Improve syntax #20448
Merged
Improve syntax #20448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you're continuing on your old branch. That one was merged into master already. Would suggest to update your fork to master and then branch from that. Less noise in the commit history and no need for merge commits. (We squash so I think it doesn't matter much, so it's more about reviewer noise). I think that's also the reason for the failing test, as that was fixed some time yesterday. lgtm otherwise |
jfrolich
force-pushed
the
improve-syntax
branch
from
0dadf00 to
59508bd
Compare
|
Cleaned up the history. Sorry. I fixed it before pulling in master. |
blainekasten
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change recommended by @pvdz (#20330 (comment))