Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Fix bootstrap CI #20452

Merged
merged 2 commits into from
Jan 7, 2020
Merged

chore(gatsby): Fix bootstrap CI #20452

merged 2 commits into from
Jan 7, 2020

Conversation

blainekasten
Copy link
Contributor

This fixes the bootstrap issue we are seeing in CI. Not sure when or why this was removed but we need it to compile the typescripts

@blainekasten blainekasten requested a review from a team as a code owner January 7, 2020 16:19
m-allanson
m-allanson previously approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@m-allanson
Copy link
Contributor

Oh, should the yarn.lock be updated too?

@blainekasten
Copy link
Contributor Author

@m-allanson oddly enough running yarn does not update the lock. I'm pretty sure this dependency is in the lock but just was removed from the package list somehow.. it's very confusing, but it fixes it /shrug

@sidharthachatterjee sidharthachatterjee self-requested a review January 7, 2020 18:30
sidharthachatterjee
sidharthachatterjee approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 7, 2020
@wardpeet
Copy link
Contributor

wardpeet commented Jan 7, 2020

@m-allanson oddly enough running yarn does not update the lock. I'm pretty sure this dependency is in the lock but just was removed from the package list somehow.. it's very confusing, but it fixes it /shrug

yes it is.

I need this sooooo badly!

@gatsbybot gatsbybot merged commit edd7457 into master Jan 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/bootstrap-ci branch January 7, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@m-allanson m-allanson Awaiting requested review from m-allanson

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blainekasten @m-allanson @wardpeet @sidharthachatterjee @gatsbybot