chore(gatsby): Begin typing the redux code #20457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladar
reviewed
Jan 9, 2020
|
Is it ready for review? Tests are failing at the moment. |
pieh
reviewed
Jan 10, 2020
blainekasten
force-pushed
the
start-typing-redux
branch
from
00ffba7 to
c7d385b
Compare
blainekasten
added
the
type: maintenance
blainekasten
commented
Jan 10, 2020
| @@ -52,7 +52,9 @@ module.exports = { | |||
| }, | |||
| }, | |||
| collectCoverageFrom: coverageDirs, | |||
| reporters: [`default`].concat(useCoverage ? `jest-junit` : []), | |||
| reporters: process.env.CI | |||
| ? [[`jest-silent-reporter`, { useDots: true }]] | |||
There was a problem hiding this comment.
this is to make debugging our CI test failures easier. Right now the output is so large it takes a while for circle ci to actually render the test output. This change makes it so that we only report test failures in CI.
ascorbic
reviewed
Jan 15, 2020
pvdz
approved these changes
Jan 15, 2020
| @@ -32,26 +39,30 @@ const readState = () => { | |||
| } catch (e) { | |||
| // ignore errors. | |||
| } | |||
| return {} | |||
| // BUG: Would this not cause downstream bugs? seems likely. Why wouldn't we just | |||
There was a problem hiding this comment.
This is what somebody else should check into. I don't know :/
There was a problem hiding this comment.
Yeah. Me either, but it's existing functionality.. I need to explore that more with somebody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds types to some of the redux code. Trying to do just small bits so the reviews are easier. There are lot's of any's and more work to do. But this is a decent start!