Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Fix typo in 'eslint-plugin-jsx-a11y' #20471

Merged
merged 1 commit into from
Jan 8, 2020
Merged

chore(docs): Fix typo in 'eslint-plugin-jsx-a11y' #20471

merged 1 commit into from
Jan 8, 2020

Conversation

jaydattc
Copy link
Contributor

@jaydattc jaydattc commented Jan 8, 2020

Description

Name of plugin 'eslint-plugin-jsx-a11y' is misspelled as 'eslint-jsx-plugin-a11y', which can confuse readers as the package does not exist on npm's package repository.

Documentation

https://www.gatsbyjs.org/docs/making-your-site-accessible/#linting-with-eslint-jsx-plugin-a11y

Related Issues

…jsx-plugin-a11y'

name of plugin 'eslint-plugin-jsx-a11y' is misspelled as 'eslint-jsx-plugin-a11y', which can confuse readers as the package does not exist on npm's package repository.
@jaydattc jaydattc requested a review from a team as a code owner January 8, 2020 10:26
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! 👍

@LekoArts LekoArts changed the title changing name to 'eslint-plugin-jsx-a11y' instead of 'eslint-jsx-plugin-a11y' chore(docs): Fix typo in 'eslint-plugin-jsx-a11y' Jan 8, 2020
@LekoArts LekoArts added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Jan 8, 2020
@LekoArts LekoArts merged commit e351aad into gatsbyjs:master Jan 8, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2020

Holy buckets, @jaydattc — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@jaydattc jaydattc deleted the patch-1 branch January 9, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants