-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(benchmarks): add circleci job #20490
Conversation
0ecea0a
to
6b6a3af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments. You probably need to add the semi before merging. The 100k run is up to you :)
6b6a3af
to
a03ccbb
Compare
I don't know if this is of any relevance. But it is possible to specify a resource class if you want to use more vCPUs or RAM. Docs here and an example where we do this here. |
@m-allanson Using |
a03ccbb
to
bc22ac6
Compare
Configured |
bc22ac6
to
b4f825c
Compare
Added README describing benchmark interface |
Co-authored-by: Dustin Schau <dustinschau@gmail.com>
b4f825c
to
b530c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@DSchau Can you give this a look? It says I need a review from you and/or Learning Team. |
With the approval from @pvdz and myself -- let's get this merged. Thanks @nicholascapo! |
Description
Run each benchmark in CircleCI.
One run for each value of NUM_PAGES
Each benchmark needs to ensure that any generated files are cleaned before the build starts (specifically it needs to clean during the postinstall script).
Co-authored-by: Dustin Schau dustinschau@gmail.com