Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(benchmarks): add circleci job #20490

Merged
merged 1 commit into from
Jan 13, 2020
Merged

feat(benchmarks): add circleci job #20490

merged 1 commit into from
Jan 13, 2020

Conversation

nicholascapo
Copy link
Contributor

Description

Run each benchmark in CircleCI.
One run for each value of NUM_PAGES

Each benchmark needs to ensure that any generated files are cleaned before the build starts (specifically it needs to clean during the postinstall script).

Co-authored-by: Dustin Schau dustinschau@gmail.com

@nicholascapo nicholascapo requested review from pvdz and DSchau January 8, 2020 21:31
@nicholascapo nicholascapo requested a review from a team as a code owner January 8, 2020 21:31
pvdz
pvdz previously approved these changes Jan 9, 2020
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. You probably need to add the semi before merging. The 100k run is up to you :)

scripts/build-benchmark.sh Outdated Show resolved Hide resolved
@m-allanson
Copy link
Contributor

I don't know if this is of any relevance. But it is possible to specify a resource class if you want to use more vCPUs or RAM. Docs here and an example where we do this here.

@nicholascapo
Copy link
Contributor Author

nicholascapo commented Jan 9, 2020

@m-allanson Using resource_class: xlarge sounds good.
Are we concerned about how that might effect the benchmark?
Or should we just give it those resources?

@nicholascapo
Copy link
Contributor Author

Configured resource_class: xlarge
Switched to del-cli in postinstall scripts to support running benchmarks on Windows.

@nicholascapo nicholascapo requested a review from a team as a code owner January 9, 2020 20:35
@nicholascapo
Copy link
Contributor Author

Added README describing benchmark interface

@nicholascapo nicholascapo requested a review from pvdz January 9, 2020 20:35
Co-authored-by: Dustin Schau <dustinschau@gmail.com>
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicholascapo
Copy link
Contributor Author

@DSchau Can you give this a look? It says I need a review from you and/or Learning Team.

@DSchau
Copy link
Contributor

DSchau commented Jan 13, 2020

With the approval from @pvdz and myself -- let's get this merged.

Thanks @nicholascapo!

@DSchau DSchau merged commit 08c78c8 into master Jan 13, 2020
@DSchau DSchau deleted the benchmarks/circleci branch January 13, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants