-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accessibility user testing post #20540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The only question I have is around formatting: I believe on other pages with Note asides we keep formatting the same and don't pull it into a quote block. Are we setting a new precedent?
Thanks for the PR @marcysutton! I have a similar question to @madalynrose, but other than that I think this is a great update. Awesome to keep blogs as living documents, especially highly referenced topics like this one. |
Great question about the blockquote. It's variable throughout docs / blog posts, so I made an update to remove the blockquote but keep the note. Let me know if that works better...? |
Thanks for the reviews! I don't know what's going on with the Gatsby Build Service, but given it's an update to a pre-existing Markdown file I'm going to go ahead and merge it. |
Holy buckets, @marcysutton — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
Since the blog post on accessible client-side routing and user testing was published in July, the recommended technique has evolved a bit. I updated the post to explain the latest rationale and include links to both the virtual talk where I retested it with Sam from Fable Tech Labs, and the example source code.
This has been on my mind for a while so I'm submitting the PR now! I tried to balance detail and understanding of the technique here, so let me know if it doesn't make sense.
Documentation
N/A
Related Issues
None