Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accessibility user testing post #20540

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

marcysutton
Copy link
Contributor

Description

Since the blog post on accessible client-side routing and user testing was published in July, the recommended technique has evolved a bit. I updated the post to explain the latest rationale and include links to both the virtual talk where I retested it with Sam from Fable Tech Labs, and the example source code.

This has been on my mind for a while so I'm submitting the PR now! I tried to balance detail and understanding of the technique here, so let me know if it doesn't make sense.

Documentation

N/A

Related Issues

None

@marcysutton marcysutton requested a review from a team as a code owner January 11, 2020 03:29
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! The only question I have is around formatting: I believe on other pages with Note asides we keep formatting the same and don't pull it into a quote block. Are we setting a new precedent?

@laurieontech
Copy link
Contributor

Thanks for the PR @marcysutton! I have a similar question to @madalynrose, but other than that I think this is a great update. Awesome to keep blogs as living documents, especially highly referenced topics like this one.

@marcysutton
Copy link
Contributor Author

Great question about the blockquote. It's variable throughout docs / blog posts, so I made an update to remove the blockquote but keep the note. Let me know if that works better...?

@marcysutton
Copy link
Contributor Author

Thanks for the reviews! I don't know what's going on with the Gatsby Build Service, but given it's an update to a pre-existing Markdown file I'm going to go ahead and merge it.

@marcysutton marcysutton merged commit 0f44d23 into master Jan 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-a11y-user-testing-post branch January 16, 2020 02:42
@gatsbot
Copy link

gatsbot bot commented Jan 16, 2020

Holy buckets, @marcysutton — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants