Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sites.yml - Add a gatsby-animate-blog site #20590

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Update sites.yml - Add a gatsby-animate-blog site #20590

merged 2 commits into from
Jan 15, 2020

Conversation

luffyZh
Copy link
Contributor

@luffyZh luffyZh commented Jan 14, 2020

Submit to Showcase site named gatsby-animate-blog.

It's a simple && cool gatsby blog starter.

@luffyZh luffyZh requested a review from a team as a code owner January 14, 2020 07:25
@laurieontech
Copy link
Contributor

Thanks for the PR! I noticed that the README instructions use yarn commands instead of gatsby.

We encourage documenting gatsby develop (and gatsby build) as a way to run your site for the following reasons:

  • It’s consistent with the rest of our documentation so reduces the likelihood of confusion for our users
  • It’s easier to pass in command line flags to gatsbyAlso, gatsby-cli is already a required global dependency when using Gatsby.

Could you please update the README to follow this?

@luffyZh
Copy link
Contributor Author

luffyZh commented Jan 15, 2020

Thanks for the PR! I noticed that the README instructions use yarn commands instead of gatsby.

We encourage documenting gatsby develop (and gatsby build) as a way to run your site for the following reasons:

* It’s consistent with the rest of our documentation so reduces the likelihood of confusion for our users

* It’s easier to pass in command line flags to gatsbyAlso, gatsby-cli is already a required global dependency when using Gatsby.

Could you please update the README to follow this?

Of course! Thanks for the suggestion. It has been revised. https://github.com/luffyZh/gatsby-animate-blog/blob/master/README.md

@laurieontech
Copy link
Contributor

Awesome! Thanks for updating. Getting this merged now.

@laurieontech laurieontech merged commit 79b64aa into gatsbyjs:master Jan 15, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 15, 2020

Holy buckets, @luffyZh — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants