Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-source-shopify Update API version to 2019 07 #20612

Merged
merged 3 commits into from
Jan 15, 2020

Conversation

cjkihl
Copy link
Contributor

@cjkihl cjkihl commented Jan 15, 2020

Description

This PR will update the Shopify Storefront API to the supported version 2019-07.

An option to choose API-version is also added. This is good if you also connect to the Storefront API in the client as well and want to use the same endpoint.

Documentation

https://www.gatsbyjs.org/packages/gatsby-source-shopify

https://help.shopify.com/en/api/versioning
https://help.shopify.com/en/api/storefront-api/reference/queryroot

Related Issues

Fixes: #20611

@cjkihl cjkihl requested review from a team as code owners January 15, 2020 02:11
@vladar
Copy link
Contributor

vladar commented Jan 15, 2020

Tests are failing. Mind taking a look?

@cjkihl
Copy link
Contributor Author

cjkihl commented Jan 15, 2020

Sure 🙂

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end!

Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally on our Gatsby Swag store and it fixed it (was broken before this PR). Great job!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 15, 2020
@gatsbybot gatsbybot merged commit f379283 into gatsbyjs:master Jan 15, 2020
@cjkihl
Copy link
Contributor Author

cjkihl commented Jan 15, 2020

Thank you @vladar. I realized I got my credit in the swag-store so I just bought a Cap! 😄.
Thanks for making Gatsby the best Site-generator 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatsby-source-shopify is using a deprecated API
4 participants