feat(www): Pull in translated gatsby docs (ENABLE_LOCALIZATIONS env var needed) #20637
Conversation
| @@ -4,7 +4,7 @@ import { graphql, useStaticQuery } from "gatsby" | |||
|
|
|||
| import gatsbyIcon from "../assets/gatsby-icon.png" | |||
|
|
|||
| const SiteMetadata = ({ pathname }) => { | |||
| const SiteMetadata = ({ pathname, locale }) => { | |||
There was a problem hiding this comment.
Is it better to pull in context or pass the locale down? SiteMetadata is so far only used in Layout
There was a problem hiding this comment.
For the current setup I don't think it'll make a difference. I would consider using Context if the component e.g. would be used in MDX (for ease of use).
| @@ -475,6 +487,7 @@ exports.createPages = ({ graphql, actions, reporter }) => { | |||
| node { | |||
| fields { | |||
| slug | |||
There was a problem hiding this comment.
It might end up causing confusion since here, "slug = path without locale".
There was a problem hiding this comment.
I guess in the interim phase we have to live with that, once we have all parts of the site we could make a localizedSlug or localize the slug
|
Is there a preview of this we can look at? |
|
@KyleAMathews I'm trying to build it on Gatsby Cloud but it's been finnicky, and there's currently no way to re-trigger a build AFAIK. Do we not have it set up to create a preview build on PRs? |
|
Here's a version of it with localizations not enabled, to test that everything works as before: |
|
It's not setup yet for preview builds. If you add your fork as a site however it'll build your branches. |
pieh
changed the title
Description
Pull in translated gatsby docs and display those docs on the site.
Live Example
https://build-57f60042-fb09-471c-9527-4479f5ba2c36.gtsb.io/es/tutorial/
Notes
ENABLE_LOCALIZATIONSvariableFollow-up Issues
localizedLink(and lint against using the default gatsby link)Related Issues
fixes: #19353 #17759