Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmarks): Increase minimum version of gatsby to meet Cloud requirement #20652

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

nicholascapo
Copy link
Contributor

Description

Cloud currently requires that the version of gatsby be at least 2.1.0, which is not the same as *.

From https://www.npmjs.com/package/semver#x-ranges-12x-1x-12- :

  • := >=0.0.0 (Any version satisfies)

Bump the version so we can test the benchmarks sites in Cloud.

@nicholascapo nicholascapo requested a review from a team as a code owner January 16, 2020 18:56
@nicholascapo nicholascapo requested a review from pvdz January 16, 2020 18:56
@pieh pieh merged commit 1c9916a into master Jan 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the benchmarks_minimum_gatsby_version branch January 17, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants