chore(gatsby): Deregister all events to the queue after batch #20798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The queue was retained for develop mode which led to the same event handlers being registered over and over again, which led to strange artifacts in the output. With this change the events are aggressively deregistered from the queue when it finishes or fails. Fixes #20787
vladar
reviewed
Jan 23, 2020
sidharthachatterjee
approved these changes
Jan 23, 2020
sidharthachatterjee
added
the
bot: merge on green
|
For future reference; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The queue was retained for develop mode which led to the same event handlers being registered over and over again, which led to strange artefacts in the output.
With this change the events are aggressively deregistered from the queue when it finishes or fails.
Regression introduced in #20606
Fixes #20787