Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): structured error might be a string #20909

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

pvdz
Copy link
Contributor

@pvdz pvdz commented Jan 27, 2020

Addresses this comment: #20730 (comment)

Observed a case where the err value is actually a string. This fix should resolve that case too (although to be fair we should always throw an Error instance or something similar)

@pvdz pvdz requested a review from a team as a code owner January 27, 2020 16:34
@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 27, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gatsbybot gatsbybot merged commit 7e40b21 into master Jan 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the structured-string-error branch January 27, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants