fix(gatsby): Fix missing fragment definition #21081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Jan 31, 2020
| @@ -435,7 +435,9 @@ const determineUsedFragmentsForDefinition = ( | |||
| ) => { | |||
| const { def, name, isFragment, filePath } = definition | |||
| const cachedUsedFragments = fragmentsUsedByFragment.get(name) | |||
| if (cachedUsedFragments) { | |||
|
|
|||
| // `cachedUsedFragments` could be a Set with size 0 which happens to be truthy | |||
There was a problem hiding this comment.
Note that Set with 0 size can be correct (i.e. when fragment doesn't actually use other fragments).
The problem here is sometimes it's 0 when it shouldn't be
So this adds additional works sometimes, but it's easiest hot fix we can come up without diving too much into this code, which will require @vladar expertise most likely
sidharthachatterjee
force-pushed
the
fix/fragment-caching
branch
from
5c7fced to
6b31ea3
Compare
|
We've published a canary in |
|
Closing this in favor of the successor PR: #21128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some Fragment definitions were missing due to the code path in
gatsby/packages/gatsby/src/query/query-compiler.js
Line 438 in 9199419
This is a hot fix which adds a check for the size of the Set
Fixes #20984