Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change create-pages to use async #21210

Closed
wants to merge 3 commits into from
Closed

change create-pages to use async #21210

wants to merge 3 commits into from

Conversation

tesseralis
Copy link
Contributor

Description

Change createPages to use async/await instead of promises.

Related Issues

Part of #21209

@tesseralis tesseralis requested a review from a team as a code owner February 5, 2020 01:50
@dvrylc dvrylc mentioned this pull request Feb 5, 2020
Merged
2 tasks
sidharthachatterjee
sidharthachatterjee previously approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 9, 2020
sidharthachatterjee
sidharthachatterjee approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@sidharthachatterjee
Copy link
Contributor

@tesseralis Help fix that merge conflict please?

@tesseralis
Copy link
Contributor Author

@sidharthachatterjee I think I'm just going to close this in favor of #21217, since it does that and more.

@tesseralis tesseralis closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesseralis @sidharthachatterjee